Computer: Delete existing AD Computer object when joining Computer to Domain #386

nickgw · 2022-05-18T01:01:57Z

Pull Request (PR) description

When joining a computer to a domain, if a computer object with the same name already exists in the domain it will be deleted.

This Pull Request (PR) fixes the following issues

Task list

Added an entry to the change log under the Unreleased section of the
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
Resource documentation added/updated in README.md.
Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
Comment-based help added/updated.
Localization strings added/updated in all localization files as appropriate.
Examples appropriately added/updated.
Unit tests added/updated. See DSC Community Testing Guidelines.
Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
New/changed code adheres to DSC Community Style Guidelines.

This change is

codecov · 2022-05-18T22:38:37Z

Codecov Report

Merging #386 (f59de8f) into main (49b3657) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #386   +/-   ##
===================================
  Coverage    90%    90%           
===================================
  Files        17     17           
  Lines      1690   1716   +26     
===================================
+ Hits       1528   1554   +26     
  Misses      162    162

Impacted Files	Coverage Δ
source/DSCResources/DSC_Computer/DSC_Computer.psm1	`90% <100%> (+1%)`	⬆️

kilasuit · 2022-05-21T11:05:05Z

@nickgw Please change use of backticks in your code to us splatting instead as per https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_splatting?view=powershell-7.2

nickgw · 2022-05-21T13:20:57Z

@nickgw Please change use of backticks in your code to us splatting instead as per https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_splatting?view=powershell-7.2

@kilasuit Should be all set now now

kilasuit

Reviewed 2 of 4 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nickgw)

nickgw

Reviewed 2 of 4 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nickgw)

PlagueHO · 2022-05-23T05:27:54Z

Hi @nickgw - I've merged your other PR (Awesome, thank you), but it's caused some conflicts. Can you resolve?

nickgw · 2022-05-23T14:55:58Z

Hi @nickgw - I've merged your other PR (Awesome, thank you), but it's caused some conflicts. Can you resolve?

Hey @PlagueHO , thanks! I've resolved the merge conflicts.

nickgw · 2022-05-23T15:01:19Z

@PlagueHO I didn't link the issue I was resolving on the other PR correctly. You can close this out: #234

PlagueHO · 2022-05-27T07:52:05Z

Thanks @nickgw - another great job and much appreciated. I'll get onto review tomorrow.

PlagueHO

Reviewed 3 of 4 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 25 unresolved discussions (waiting on @nickgw)

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 697 at r5 (raw file):

    .PARAMETER Name
        Name of the computer to search for in the given domain

Nit, for consistency: Can you add a full stop at the end of this line?

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 700 at r5 (raw file):

    .PARAMETER Domain
        Domain to search

Nit, for consistency: Can you add a full stop at the end of this line?

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 703 at r5 (raw file):

    .PARAMETER Credential
        Credential to search domain with

Nit, for consistency: Can you add a full stop at the end of this line?

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 728 at r5 (raw file):

    $searcher = New-Object -TypeName System.DirectoryServices.DirectorySearcher
    $searcher.Filter = "(&(objectCategory=computer)(objectClass=computer)(cn=$Name))"
    if ( $DomainName -notlike "LDAP://*")

Can you remove space after the (?

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 739 at r5 (raw file):

            ArgumentList = @(
                $DomainName,
                $($Credential.UserName),

Are the outer braces needed on this line and the next?

E.g. could this be:

            ArgumentList = @(
                $DomainName,
                $Credential.UserName,
                $Credential.GetNetworkCredential().password
            )

I could be wrong though...

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 746 at r5 (raw file):

        $searchRoot = New-Object @params
    }
    catch

What exceptions are typically handled here? Can we just ditch the whole try/catch and let the exception get handled by the DSC exception handler?

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 760 at r5 (raw file):

    .PARAMETER Path
        Path to Object to delete

Nit, for consistency: Can you add a full stop at the end of this line?

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 763 at r5 (raw file):

    .PARAMETER Credential
        Credential to authenticate to the domain

Nit, for consistency: Can you add a full stop at the end of this line?

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 786 at r5 (raw file):

            ArgumentList = @(
                $DomainName,
                $($Credential.UserName),

Are the outer braces needed on this line and the next?

E.g. could this be:

            ArgumentList = @(
                $DomainName,
                $Credential.UserName,
                $Credential.GetNetworkCredential().password
            )

I could be wrong though...

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 795 at r5 (raw file):

        $adsiObj.DeleteTree()
    }
    catch

What exceptions are typically handled here? Can we just ditch the whole try/catch and let the exception get handled by the DSC exception handler?

tests/Unit/DSC_Computer.Tests.ps1 line 1286 at r5 (raw file):

                }

                Mock 'New-Object' { New-Object 'fake_adsi_searcher' } `

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Suggestion:

Mock -CommandName New-Object -MockWith {
        New-Object -TypeName 'fake_adsi_searcher'
    } `
    -ParameterFilter {
        $TypeName -and
        $TypeName -eq 'System.DirectoryServices.DirectorySearcher'
    }

tests/Unit/DSC_Computer.Tests.ps1 line 1292 at r5 (raw file):

                    }

                It 'Throws if name is to long' {

Can you verify that the expected error is being thrown? E.g. Check the error message if possible. I'm assuming that this is actually checking the parameter verifiers?

Also, start It block with 'Should' (just a standard we adopted):

Code snippet:

It 'Should throw the expected exception if the name is to long' {

tests/Unit/DSC_Computer.Tests.ps1 line 1302 at r5 (raw file):

                }

                It 'Throws if name contains illegal characters' {

It should verify that the expected exception is thrown. Can usually just check the error message if it's mocked, or check the error object if it's a custom exception your code is throwing.

Code snippet:

It 'Should throw the expected exception if name contains illegal characters' {

tests/Unit/DSC_Computer.Tests.ps1 line 1313 at r5 (raw file):

                It 'Returns ADSI object with ADSI path ' {

Can you remove blank line here?

tests/Unit/DSC_Computer.Tests.ps1 line 1314 at r5 (raw file):

                It 'Returns ADSI object with ADSI path ' {

                    Mock 'New-Object' { New-Object 'fake_adsi_directoryentry' } `

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Suggestion:

Mock -CommandName New-Object -MockWith {
        New-Object -TypeName 'fake_adsi_directoryentry'
    } `
    -ParameterFilter {
        $TypeName -and
        $TypeName -eq 'System.DirectoryServices.DirectoryEntry'
    }

tests/Unit/DSC_Computer.Tests.ps1 line 1330 at r5 (raw file):

                It 'Returns ADSI object with domain name' {

Can you remove blank line here?

tests/Unit/DSC_Computer.Tests.ps1 line 1335 at r5 (raw file):

                        $TypeName -and
                        $TypeName -eq 'System.DirectoryServices.DirectoryEntry'
                    }

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Suggestion:

Mock -CommandName New-Object -MockWith {
        New-Object -TypeName 'fake_adsi_directoryentry'
    } `
    -ParameterFilter {
        $TypeName -and
        $TypeName -eq 'System.DirectoryServices.DirectoryEntry'
     }

tests/Unit/DSC_Computer.Tests.ps1 line 1346 at r5 (raw file):

                }

                It 'Should throw if Credential is incorrect' {

It should verify that the expected exception is thrown. Can usually just check the error message if it's mocked, or check the error object if it's a custom exception your code is throwing.

Suggestion:

                It 'Should throw the expected exception if Credential is incorrect' {

tests/Unit/DSC_Computer.Tests.ps1 line 1347 at r5 (raw file):

                It 'Should throw if Credential is incorrect' {
                    Mock 'New-Object' { Write-Error -message "error" } `

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Suggestion:

Mock -CommandName New-Object -MockWith {
        Write-Error -Message 'error'
    } `
    -ParameterFilter {
        $TypeName -and
        $TypeName -eq 'System.DirectoryServices.DirectoryEntry'
    }

tests/Unit/DSC_Computer.Tests.ps1 line 1359 at r5 (raw file):

                            -Credential $credential `
                            -Verbose
                    } | Should -Throw

Can you verify that the expected exception thrown? E.g. Check the error text?

tests/Unit/DSC_Computer.Tests.ps1 line 1365 at r5 (raw file):

            Context 'DSC_Computer\Delete-ADSIObject' {

Can you remove blank line here?

tests/Unit/DSC_Computer.Tests.ps1 line 1373 at r5 (raw file):

                }

                It 'Deletes ADSI Object' {

Suggestion:

It 'Should delete the ADSI Object' {

tests/Unit/DSC_Computer.Tests.ps1 line 1374 at r5 (raw file):

                It 'Deletes ADSI Object' {
                    Mock 'New-Object' { New-Object 'fake_adsi_directoryentry' } `

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Suggestion:

                    Mock -CommandName New-Object -MockWith {
                        New-Object 'fake_adsi_directoryentry'
                    } `
                    -ParameterFilter {
                        $TypeName -and
                        $TypeName -eq 'System.DirectoryServices.DirectoryEntry'
                    }

tests/Unit/DSC_Computer.Tests.ps1 line 1395 at r5 (raw file):

                                -Credential $credential`
                                -Verbose
                    } | Should -Throw

Is it possible to verify the correct/expected exception is being thrown? It looks like this is checking the parameter verifier - so should be possible?

tests/Unit/DSC_Computer.Tests.ps1 line 1399 at r5 (raw file):

                It 'Should throw if Credential is incorrect' {
                    Mock 'New-Object' { Write-Error -message "error" } `

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Suggestion:

                    Mock -CommandName New-Object -MockWith {
                            Write-Error -message 'error'
                        } `
                        -ParameterFilter {
                            $TypeName -and
                            $TypeName -eq 'System.DirectoryServices.DirectoryEntry'
                        }

tests/Unit/DSC_Computer.Tests.ps1 line 1410 at r5 (raw file):

                            -Credential $credential `
                            -Verbose
                    } | Should -Throw

FYI, this might not be possible (why it's info only), but can the exception be verified - e.g that the correct one is being thrown?

nickgw

Reviewable status: 1 of 4 files reviewed, 20 unresolved discussions (waiting on @PlagueHO)

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 728 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you remove space after the (?

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 739 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Are the outer braces needed on this line and the next?

E.g. could this be:

            ArgumentList = @(
                $DomainName,
                $Credential.UserName,
                $Credential.GetNetworkCredential().password
            )

I could be wrong though...

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 746 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

What exceptions are typically handled here? Can we just ditch the whole try/catch and let the exception get handled by the DSC exception handler?

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 786 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Are the outer braces needed on this line and the next?

E.g. could this be:

            ArgumentList = @(
                $DomainName,
                $Credential.UserName,
                $Credential.GetNetworkCredential().password
            )

I could be wrong though...

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 795 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

What exceptions are typically handled here? Can we just ditch the whole try/catch and let the exception get handled by the DSC exception handler?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1286 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1292 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you verify that the expected error is being thrown? E.g. Check the error message if possible. I'm assuming that this is actually checking the parameter verifiers?

Also, start It block with 'Should' (just a standard we adopted):

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1302 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

It should verify that the expected exception is thrown. Can usually just check the error message if it's mocked, or check the error object if it's a custom exception your code is throwing.

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1313 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you remove blank line here?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1314 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1330 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you remove blank line here?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1335 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1346 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

It should verify that the expected exception is thrown. Can usually just check the error message if it's mocked, or check the error object if it's a custom exception your code is throwing.

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1347 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1359 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you verify that the expected exception thrown? E.g. Check the error text?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1365 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you remove blank line here?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1373 at r5 (raw file):

                }

                It 'Deletes ADSI Object' {

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1374 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1395 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Is it possible to verify the correct/expected exception is being thrown? It looks like this is checking the parameter verifier - so should be possible?

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1399 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you use parameter names and remove quotes around command and tweak formatting to align to standards?

Done.

PlagueHO

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @nickgw and @PlagueHO)

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 795 at r5 (raw file):

Previously, nickgw (Nick G) wrote…

Done.

It doesn't look like this changed. But see the discussion above about try...catch to suppress an exception in DSC.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 751 at r6 (raw file):

    catch
    {
        New-InvalidOperationException -Message ($script:localizedData.InvalidUserNameorPassword -f $Credential.Username)

Is this the only possible cause of an exception here? If there are other causes, then this exception message would be misleading. Could you just eliminate the try... catch and just let the method throw its own exception?

E.g. just replace the whole block with:

return $searcher.FindOne()

Although if you want to prevent an exception entirely and allow DSC to keep processing even in the case of an exception then the try...catch is neccessary - but you're probably not safe assuming that the cause of the exception is a bad username/password. Does that make sense?

tests/Unit/DSC_Computer.Tests.ps1 line 1374 at r5 (raw file):

Previously, nickgw (Nick G) wrote…

Done.

I think this one didn't change (still in incorrect format).

tests/Unit/DSC_Computer.Tests.ps1 line 1399 at r5 (raw file):

Previously, nickgw (Nick G) wrote…

Done.

I think this one didn't change (still in incorrect format).

tests/Unit/DSC_Computer.Tests.ps1 line 1355 at r6 (raw file):

                It 'Should throw the expected exception if Credential is incorrect' {
                    Mock 'New-Object' { Write-Error -message "Invalid Credentials" } `

I missed this - can you tweak the format to be:

Mock -CommandName New-Object -MockWith {
    Write-Error -Message 'Invalid Credentials' 
} `

tests/Unit/DSC_Computer.Tests.ps1 line 1367 at r6 (raw file):

                            -Credential $credential `
                            -Verbose
                    } | Should -Throw "Invalid Credentials"

Can you use single quotes here?

…xpose itself

nickgw

Reviewable status: 2 of 4 files reviewed, 11 unresolved discussions (waiting on @PlagueHO)

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 795 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

It doesn't look like this changed. But see the discussion above about try...catch to suppress an exception in DSC.

Done.

source/DSCResources/DSC_Computer/DSC_Computer.psm1 line 751 at r6 (raw file):

doesn't look like this changed. But see the discussion above about try...catch to suppress an exception in DSC.
I see what you're saying and removed the try/catch for both of the dotnet methods.

tests/Unit/DSC_Computer.Tests.ps1 line 1374 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I think this one didn't change (still in incorrect format).

I think I got this one now.

tests/Unit/DSC_Computer.Tests.ps1 line 1399 at r5 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I think this one didn't change (still in incorrect format).

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1355 at r6 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I missed this - can you tweak the format to be:

Mock -CommandName New-Object -MockWith {
    Write-Error -Message 'Invalid Credentials' 
} `

Done.

tests/Unit/DSC_Computer.Tests.ps1 line 1367 at r6 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you use single quotes here?

Done.

PlagueHO

Awesome job @nickgw - just one minor tweak to the CHANGELOG.md to ensure the release process works correctly and then we can merge.

Reviewed 2 of 2 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nickgw)

CHANGELOG.md line 7 at r8 (raw file):

## [Unreleased]
- Computer

Minor thing I just noticed that might upset the release process: Can you move this down under the ### Added section? Also, can you add a blank line after the ### Added.

E.g.

### Added

- Computer
  - Support Options Parameter for domain join - Fixes [Issue #234](https://github.com/dsccommunity/ComputerManagementDsc/issues/234).
  - When joining a computer to a domain, existing AD computer objects will be deleted.

PlagueHO

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nickgw)

tests/Unit/DSC_Computer.Tests.ps1 line 1356 at r8 (raw file):

                It 'Should throw the expected exception if Credential is incorrect' {
                    Mock -CommandName New-Object -MockWith {
                         Write-Error -message "Invalid Credentials"

Nit, Doh! Missed one minor thing:

Write-Error -Message 'Invalid Credentials'

PlagueHO

Reviewed 2 of 2 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nickgw)

nickgw added 7 commits May 17, 2022 15:43

First stab at computer object deletion if it exists already

35a7c41

Using functions and adding some verbose output

f37afb2

Updating changelog and fixing formatting

9b87213

Fixing up functions

27852f7

fixing verbose message

77423d3

adding tests

0675006

Fixing mocks for adsi funcs in workgroup join

342891b

nickgw added 2 commits May 19, 2022 12:47

initial getadsicomputer tests

b520ab1

Add test with mocks of dot net objects

a50330e

PlagueHO added the needs review The pull request needs a code review. label May 20, 2022

nickgw added 18 commits May 20, 2022 10:57

Initial delete-adsiobject test

a92bdb1

Updating tests for adsi stuff

fd7a2c6

Updating tests

e0d919d

mock the psautomation type better

fc0889a

mock the psbase obj type with property

b2c131a

Removing unnecessary property of fake_psbase_object

987fc1b

moving scope

b807a02

does this work

7fb77f7

no quotes

3d658b6

Simplify

498639d

no need for nested class

5680604

Adding mocks for exceptions

3c07223

Adding validation for path in delete-adsiobject

cb6c1d0

updating tests

729e72a

rescope new-object

8164665

remove throw for write-error

77255ee

add space between credential and backtick

8e9af1e

add space between credential and backtick

f14498f

kilasuit reviewed May 22, 2022

View reviewed changes

nickgw commented May 22, 2022

View reviewed changes

Resolving merge conflicts

5cfb233

fixing blocks from merge conflict

9f7919f

PlagueHO requested changes May 28, 2022

View reviewed changes

nickgw added 6 commits May 30, 2022 20:32

Rework Get-AdsiComputer to throw correctly

1c59352

resolving comments from PR

2e236ee

Fixing tests

7ee2284

Fixing error message quoting

1f68c52

Fixing error messages

9125fd7

Fixing validation error message

5257d52

nickgw commented May 31, 2022

View reviewed changes

PlagueHO requested changes May 31, 2022

View reviewed changes

Updating mock commands and removing try catches to let dotnet error e…

a511666

…xpose itself

nickgw commented May 31, 2022

View reviewed changes

Removing unused string

20df9dd

PlagueHO approved these changes Jun 1, 2022

View reviewed changes

nickgw added 2 commits June 1, 2022 09:25

update changelog and single quote string

9115448

changelog

f59de8f

PlagueHO approved these changes Jun 2, 2022

View reviewed changes

PlagueHO enabled auto-merge (squash) June 2, 2022 07:03

PlagueHO merged commit 438d2c2 into dsccommunity:main Jun 2, 2022

nickgw deleted the ngermany_addcomputerobjectoverwrite branch June 2, 2022 13:25

johlju removed the needs review The pull request needs a code review. label Feb 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Computer: Delete existing AD Computer object when joining Computer to Domain #386

Computer: Delete existing AD Computer object when joining Computer to Domain #386

nickgw commented May 18, 2022 •

edited

Loading

codecov bot commented May 18, 2022 •

edited

Loading

kilasuit commented May 21, 2022

nickgw commented May 21, 2022

kilasuit left a comment

nickgw left a comment

PlagueHO commented May 23, 2022

nickgw commented May 23, 2022

nickgw commented May 23, 2022

PlagueHO commented May 27, 2022

PlagueHO left a comment

nickgw left a comment

PlagueHO left a comment

nickgw left a comment

PlagueHO left a comment

PlagueHO left a comment

PlagueHO left a comment

Computer: Delete existing AD Computer object when joining Computer to Domain #386

Computer: Delete existing AD Computer object when joining Computer to Domain #386

Conversation

nickgw commented May 18, 2022 • edited Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

codecov bot commented May 18, 2022 • edited Loading

Codecov Report

kilasuit commented May 21, 2022

nickgw commented May 21, 2022

kilasuit left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

PlagueHO commented May 23, 2022

nickgw commented May 23, 2022

nickgw commented May 23, 2022

PlagueHO commented May 27, 2022

PlagueHO left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

PlagueHO left a comment

Choose a reason for hiding this comment

nickgw left a comment

Choose a reason for hiding this comment

PlagueHO left a comment

Choose a reason for hiding this comment

PlagueHO left a comment

Choose a reason for hiding this comment

PlagueHO left a comment

Choose a reason for hiding this comment

nickgw commented May 18, 2022 •

edited

Loading

codecov bot commented May 18, 2022 •

edited

Loading