Fixed issue #306

[ykuijs]

Pull Request (PR) description

This PR fixes the issue where disabling certain scheduled tasks does not work.

This Pull Request (PR) fixes the following issues

• Fixes [ScheduledTask] Disabling scheduled task fails with incorrect user name or password error #306

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md in resource folder.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[PlagueHO]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ykuijs)

---

source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 459 at r1 (raw file):

        {
            Write-Verbose -Message ($script:localizedData.DisablingExistingScheduledTask -f $TaskName, $TaskPath)
            if ($PSVersionTable.PSVersion -gt [Version]"5.0.0.0")

Nitpick - can you add blank line before this and use single quotes around 5.0.0.0? Also, can change [Version] to[System.Version]?

---

tests/Unit/DSC_ScheduledTask.Tests.ps1, line 226 at r1 (raw file):

                It 'Should remove the scheduled task in the set method' {
                    Set-TargetResource @testParameters
                    if ($PSVersionTable.PSVersion -gt [Version]"5.0.0.0")

Nitpick - can you add blank line before this and use single quotes around 5.0.0.0? Also, can change [Version] to[System.Version]?

---

tests/Unit/DSC_ScheduledTask.Tests.ps1, line 1584 at r1 (raw file):

                It 'Should disable the scheduled task in the set method' {
                    Set-TargetResource @testParameters
                    if ($PSVersionTable.PSEdition -gt [Version]"5.0.0.0")

Nitpick - can you add blank line before this and use single quotes around 5.0.0.0? Also, can change [Version] to[System.Version]?

[ykuijs]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @PlagueHO)

---

source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 459 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Nitpick - can you add blank line before this and use single quotes around 5.0.0.0? Also, can change [Version] to[System.Version]?

Done.

---

tests/Unit/DSC_ScheduledTask.Tests.ps1, line 226 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Nitpick - can you add blank line before this and use single quotes around 5.0.0.0? Also, can change [Version] to[System.Version]?

Done.

---

tests/Unit/DSC_ScheduledTask.Tests.ps1, line 1584 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Nitpick - can you add blank line before this and use single quotes around 5.0.0.0? Also, can change [Version] to[System.Version]?

Done.

[PlagueHO]

Just one minor fix (sorry about that).

Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ykuijs)

---

CHANGELOG.md, line 15 at r3 (raw file):

  - Automatically publish documentation to GitHub Wiki - Fixes [Issue #342](https://github.com/dsccommunity/ComputerManagementDsc/issues/342).

### Fixed

Doh! Any chance you could move this block into the Unreleased section? I did a release over the weekend.

[ykuijs]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

---

CHANGELOG.md, line 15 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Doh! Any chance you could move this block into the Unreleased section? I did a release over the weekend.

Done.

[PlagueHO]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

[PlagueHO]

Reviewable status: complete! all files reviewed, all discussions resolved