Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Examples to format required for Publishing - Fixes #206 #207

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Feb 16, 2019

Pull Request (PR) description

  • Updated examples to format required for publishing to PowerShell Gallery - fixes
    Issue #206.
  • Opted into Common Tests 'Validate Example Files To Be Published' and
    'Validate Markdown Links'.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you have time? This converts the module examples to prepare for auto-publishing to PS Gallery. So it is a bit of a big one.


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Feb 16, 2019
@codecov-io
Copy link

codecov-io commented Feb 16, 2019

Codecov Report

Merging #207 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #207   +/-   ##
==================================
  Coverage   90%    90%           
==================================
  Files        8      8           
  Lines      844    844           
==================================
  Hits       762    762           
  Misses      82     82

@PlagueHO
Copy link
Member Author

PlagueHO commented Mar 1, 2019

Hi @johlju - would you mind reviewing this one if you get a chance? It is so that we can start moving towards Example publishing here.

@johlju
Copy link
Member

johlju commented Mar 3, 2019

@PlagueHO Will get to this tomorrow.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Great work on these! Couldn't see anything wrong here! 🙂

Reviewed 71 of 71 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit cbb7886 into dsccommunity:dev Mar 4, 2019
@PlagueHO PlagueHO deleted the Issue-206 branch March 4, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Examples to format required for Publishing to PSGallery
3 participants