Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xScheduledTask: Move strings to localization file and HQRM - fixes #125 #126

Merged
merged 4 commits into from
Dec 23, 2017

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Dec 23, 2017

Pull Request (PR) description
Convert xScheduledTask to HQRM and move strings to Localization File. Also correct message produced when existing scheduled task trigger type is not recognized.

This Pull Request (PR) fixes the following issues:

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

@johlju - this is the last HQRM change required to this module. Would you mind reviewing if you get a chance? I can then get onto the rename and starting work on adding features again.


This change is Reviewable

@johlju
Copy link
Member

johlju commented Dec 23, 2017

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xScheduledTask/en-US/MSFT_xScheduledTask.strings.psd1, line 9 at r1 (raw file):

0

Minor, no-blocking: Maybe change to '...zero (0)...'? This and the one below.


Comments from Reviewable

@PlagueHO
Copy link
Member Author

All done - could you sign off for me? 😁 Thanks again @johlju!


Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xScheduledTask/en-US/MSFT_xScheduledTask.strings.psd1, line 9 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

0

Minor, no-blocking: Maybe change to '...zero (0)...'? This and the one below.

Done.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Dec 23, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@PlagueHO
Copy link
Member Author

Thanks again @johlju

@PlagueHO PlagueHO merged commit fb0226b into dsccommunity:dev Dec 23, 2017
@PlagueHO PlagueHO deleted the Issue-125 branch December 23, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants