BREAKING CHANGE: Deprecate AdcsOcspExtension and Replace with AdcsAuthorityInformationAccess - Fixes #Issue 101 #104
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #104 +/- ##
==================================
- Coverage 97% 94% -3%
==================================
Files 8 8
Lines 641 700 +59
==================================
+ Hits 626 664 +38
- Misses 15 36 +21 |
|
@johlju - would you mind reviewing this when you have time? |
There was a problem hiding this comment.
Reviewed 26 of 26 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @PlagueHO)
a discussion (no related file):
Since it should be possible to remove a set value using $null we should have an example showing how that is done too.
a discussion (no related file):
We should have an integration tests that clears a set configuration, e.g clears OcspUri.
DSCResources/MSFT_AdcsCertificationAuthoritySettings/MSFT_AdcsCertificationAuthoritySettings.psm1, line 109 at r2 (raw file):
'Uint32'
UInt32 (upper-case 'I')
Modules/ActiveDirectoryCSDsc.Common/ActiveDirectoryCSDsc.Common.psm1, line 26 at r2 (raw file):
{ $_ -in $commonParameters }
Should be on separate rows.
Tests/Unit/ActiveDirectoryCSDsc.Common.Tests.ps1, line 436 at r2 (raw file):
-Be $true
-BeTrue (non-blocking)
Tests/Unit/ActiveDirectoryCSDsc.Common.Tests.ps1, line 475 at r2 (raw file):
-Be $false
-BeFalse (non-blocking)
johlju
added
the
waiting for code fix
There was a problem hiding this comment.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @johlju)
a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Since it should be possible to remove a set value using
$nullwe should have an example showing how that is done too.
Done.
a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
We should have an integration tests that clears a set configuration, e.g clears
OcspUri.
Done.
DSCResources/MSFT_AdcsCertificationAuthoritySettings/MSFT_AdcsCertificationAuthoritySettings.psm1, line 109 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
'Uint32'
UInt32(upper-case 'I')
Done.
Modules/ActiveDirectoryCSDsc.Common/ActiveDirectoryCSDsc.Common.psm1, line 26 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
{ $_ -in $commonParameters }Should be on separate rows.
Done.
Tests/Unit/ActiveDirectoryCSDsc.Common.Tests.ps1, line 436 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
-Be $true
-BeTrue(non-blocking)
Done.
Tests/Unit/ActiveDirectoryCSDsc.Common.Tests.ps1, line 475 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
-Be $false
-BeFalse(non-blocking)
Done.
There was a problem hiding this comment.
Reviewable status: 24 of 34 files reviewed, 4 unresolved discussions (waiting on @johlju)
a discussion (no related file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Done.
@johlju - I completely forgot about this one. I've made the changes so should be good to review again.
There was a problem hiding this comment.
Looks good! One more to merge. 😃
Reviewed 10 of 10 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
johlju
added
ready for merge
Pull Request (PR) description
This PR deprecates AdcsOcspExtension and replaces it with AdcsAuthorityInformationAccess. This is beacuse the AdcsOcspExtension resource used a pattern that could result in conflicting configurations. The AdcsAuthorityInformationAccess also includes the ability to set the AIA URIs as well as the OCSP URIs.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
@X-Guardian - would you mind reviewing when you have a chance?
This change is