More compiler tests #122
Merged
More compiler tests #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See "The Artist Formerly Known as Bindingspec" in the Qi meeting notes for more context on this issue. We had formerly fixed this for partial application, but hadn't noticed the same issue also affected blanket templates. Recently we committed a fix for the two cases of the template being on the beginning or end (which is what partial application without a template now expands to). This adds the fix for the remaining case where a template is somewhere in the middle of the expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This adds (failing) tests for deforestation of all permutations of templates, and also fixes an "anaphoric references" issue with compiling blanket templates in connection with bindings, which we had fixed a while back for compiling partial applications, but which we hadn't noticed also affects blanket templates. I added a failing test for this yesterday and this PR resolves that test by adding the fix. So now, all tests with
make test-floware passing again. This also adds a couple of tests to validate use of keyword arguments in templates.Public Domain Dedication
(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)