Optimize PredicateRegistry for Ruby 2.7+ #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@casperisfine could you show that this optimization makes a difference for a typical dry-types usage? I don't think the registry is queried in "runtime" (when types are already defined) but I might be wrong. |
I should have specified that I found this in our boot profiling reports. Boot time is important to us so we have daily profiling of it. |
2.7 introduced `UnboundMethod#bind_call` which is much faster than doing `Method.bind(receiver).call`. And even on older rubies caching `Kernel.instance_method(:respond_to?)` in a constant will save quite a lot of extra costly allocations.
casperisfine
force-pushed
the
optimize-bind-call
branch
from
77ab46a to
5c65453
Compare
|
Ok, fair enough. I think we could a cache or something, this could be even faster but it'll require benchmarking. I'll merge it as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.7 introduced
UnboundMethod#bind_callwhich is much faster thandoing
Method.bind(receiver).call.And even on older rubies caching
Kernel.instance_method(:respond_to?)in a constant will save quite a lot of extra costly allocations.