Add missing dry/core/equalizer requires #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting these in any file where we refer to Dry::Equalizer should prevent “undefined method `Equalizer' for Dry:Module” occurring, regardless of the order of requires.
no, this was missed by an accident and now it's been revealed due to moving to dry-core |
solnic
approved these changes
Feb 15, 2021
flash-gordon
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
I am wondering why it worked before. @timriley how do you require dry-types?
|
Thanks folks :) Am releasing this as 1.5.1 now. I confirmed it fixed our build issue earlier today. I'll check back to work out how we're loading dry-types tomorrow. It's within a Rails app. |
|
@timriley FWIW - I don't think this was anything unexpected, it just happened that in your case files were loaded previously in such an order that the equalizer happened to be already loaded before loading dry-types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting these in any file where we refer to Dry::Equalizer should prevent
undefined method 'Equalizer' for Dry:Moduleoccurring, regardless of the order of requires.@solnic @flash-gordon Is there any reason these weren't here before? We get the error above today in CI when upgrading a work project to 1.5.0.