Add SVG AAM spec #42
Merged
Add SVG AAM spec #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e695832 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
aam-improvements-2
branch
2 times, most recently
from
48fc3c7 to
f932b12
Compare
drwpow
force-pushed
the
aam-improvements-2
branch
from
f932b12 to
e695832
Compare
drwpow
commented
Feb 10, 2025
| { given: ['<svg><animateTransform></animateTransform></svg>', 'animateTransform'], want: 'none' }, | ||
| ], | ||
| ['circle', { given: ['<svg><circle /></svg>', 'circle'], want: 'none' }], | ||
| ['circle (empty title)', { given: ['<svg><circle><title></title></circle></svg>', 'circle'], want: 'none' }], |
There was a problem hiding this comment.
cc @cmorten Added tests that attempt to satisfy the behavior outlined in the SVG AAM Including elements in the accessibility tree section. circle got tests for every behavior that describes; other similar elements like rect, ellipse, path, etc. follow the same codepath so it’s assumed they match
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Further addresses #25 by adding behavior and tests for SVG AAM roles.
Also adds some minor cleanup to prepare for a minor release
How to Review
Checklist