Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Dice Face Value Names #209

Closed
elmodor opened this issue Dec 17, 2022 · 1 comment
Closed

Feature: Dice Face Value Names #209

elmodor opened this issue Dec 17, 2022 · 1 comment
Labels
assets Related to assets or asset packs tweak Tweak an existing feature
Milestone
v0.2.0

Comments

@elmodor
Copy link
Contributor

elmodor commented Dec 17, 2022

Is your feature request related to a problem? Please describe.
Now that #142 is implemented, one can set a dice to a specific value.
Some games have dice which are not numbered but have images or other non numeric values - some might even have the same number multiple times (e.g. a die with face values: 0, 1, 1, 1, 2, 3).
Currently the index is used as "name" which is not very customizable.

Describe the solution you'd like
To be able to set those dice (with images and multiple numbers) it would be good to give a face value a name. This name should then be displayed when changing the dice value (#142).
This allows to describe an image or have the same name for multiple faces.

Describe alternatives you've considered

Additional context
@drwhut drwhut added the feature New feature or request label Dec 17, 2022
@drwhut drwhut added this to the v0.2.0 milestone Feb 23, 2023
@drwhut drwhut added assets Related to assets or asset packs tweak Tweak an existing feature and removed feature New feature or request labels Mar 26, 2023
drwhut added a commit that referenced this issue Jul 7, 2023
@drwhut
Finished code for configuring asset entries.
b043588 
It should now be much easier and safer to introduce new changes to
how the 'config.cfg' file is read. Now, I just need to have an easy
way to set up scene entries, to read 'stacks.cfg' files to make
collections of entries, and to test everything as well... ho boy ><
It will be worth it in the end, but this is what I dreaded most
about using unit tests, some of them are going to be absolutely
gargantuan, and I'm pretty sure the tests for this code is going
to be one of them... :|

Overall, the functionality has mostly stayed the same from before,
except for one major change: the 'face_values' dictionary used for
dice has swapped its keys and values. Previously, the keys were the
values assigned to each face, and the values were the rotations needed
to make that face point globally upwards. Now, the keys are the
rotations, and the values are the, well, values. This allows for
multiple faces to have not only the same value, but string values
are also now possible due to the CustomValue class.

As a result, once this commit is merged into master, it should
close #209.
@20kdc 20kdc mentioned this issue Sep 7, 2023
Merged
@drwhut
Copy link
Owner

drwhut commented Sep 4, 2024

Closed as of v0.1.3! 🥳

@drwhut drwhut closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assets Related to assets or asset packs tweak Tweak an existing feature
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@elmodor @drwhut