fix: augment @nuxt/schema rather than nuxt/schema
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maximilianmikus or @TurtlBbx could one of you check this and merge if good? I guess we need to ensure our typing still works correctly. Related, I guess we should add a seperate issue to improve typing of our APIs and add a type for the page object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: nuxt/nuxt#28332
nuxt/schemais a re-export of@nuxt/schemafor users to use. Modules should not augment it, or it may end up overwriting the inferred types from@nuxt/schema.(We made the change in nuxt/module-builder#295 (released in v0.8.0 of
@nuxt/module-builder) to avoid doing this in@nuxt/module-builderitself.)