Update for Jetty 9.3.0 #823
Conversation
|
The obvious downside is that we can't run tests under Java 7, because Jetty 9.3.0 is compiled against Java 8. |
|
I'd like to be able to run tests against Jetty 9.2 and Java 7. Any idea how we can make that happen? |
This method is declared in `ConnectionFactory` in Jetty 9.3.*. To be compatible with it, we should have a method with the same signature. We can't use a compile-time dependency on Jetty 9.3.*, because it's compiled against Java 8, but `dropwizard-metrics` against Java 7. Therefore, we use reflection to access this method.
|
What do you think about using reflection to access the |
|
Ping. @ryantenney, could you take a look, please? |
|
Just found this while trying to figure out why my app was failing when I tired to use Jetty 9.3. |
|
@arteam is this good to merge now? |
|
Yes, the patch should be good to merge. Last time I checked, it worked both on Jetty 9.2.* and Jetty 9.3.*. |
|
And Java7? |
|
I didn't check against Java 7, but the tests passed on Travis CI. I used reflection precisely for the reason to avoid any Java 8 dependency. |
This method is declared in `ConnectionFactory` in Jetty 9.3.*. To be compatible with it, we should have a method with the same signature. We can't use a compile-time dependency on Jetty 9.3.*, because it's compiled against Java 8, but `codahale-metrics` against Java 6. Therefore, we use reflection to access this method. Backport of #823
|
I've created #1038 to backport this feature to the 3.2 branch. For the 4.0.0 branch we can actually just avoid reflection and just implement a new method. |
This method is declared in ConnectionFactory in Jetty 9.3.*. To be compatible with it, we should have a method with the same signature. We can't use a compile-time dependency on Jetty 9.3.*, because it's compiled against Java 8, but codahale-metrics against Java 6. Therefore, we use reflection to access this method. Backport of #823
|
The implementation for 4.0.0 is tracked in #1039. |
Jetty 9.3.0 is the latest update of Jetty with some API changes.
InstrumentedConnectionFactoryto support instrumentation for Jetty 9.3.The update should be backward-compatible with Jetty 9.1 and 9.2, because we only implement a new method.