Add modules to support Jetty 12 #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschi
requested changes
Aug 25, 2023
joschi
approved these changes
Aug 25, 2023
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Nov 1, 2023
### What changes were proposed in this pull request? This pr upgrade dropwizard metrics from 4.2.19 to 4.2.21. ### Why are the changes needed? The new version includes the following major updates: - dropwizard/metrics#2652 - dropwizard/metrics#3515 - dropwizard/metrics#3523 - dropwizard/metrics#3570 The full release notes as follows: - https://github.com/dropwizard/metrics/releases/tag/v4.2.20 - https://github.com/dropwizard/metrics/releases/tag/v4.2.21 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #43608 from LuciferYang/SPARK-45743. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
joschi
added a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides basic support for Jetty 12.
Notable changes
HttpChannel.Listenerinterface doesn't exist anymore. The instrumented class here isn't ported for Jetty 12.jetty-servermodule. To allow multiple EE version implementations, theInstrumentedHandlerimplementation is moved out to a separateEExmodule. The coremetrics-jetty12module contains an abstract base class for implementations. Perspectively, themetrics-jetty12module should contain an implementation which doesn't require the servlet classes. However, the Dropwizard framework is servlet-only at the moment. The implementation without the servlet classes is therefore deferred until requested.InstrumentedQueuedThreadPoolare aligned with the super class' constructors.