Jetty Update to 9.4.21 #1490
Merged
Jetty Update to 9.4.21 #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It contains some notable internal changes (most importantly related to HttpChannel.State): jetty/jetty.project@bde8646#diff-68e74a60841dd5ec1f7edc4bd736ce18 Fix InstrumentedHandler to compile and work with pre-9.4.21 and post-9.4.21 Jetty instances, but using internal API is not a recipe for longevity. Also, created a new InstrumentedHttpChannelListener that in turn does use public API of Jetty, and should not break with minor releases.
arteam
approved these changes
Oct 19, 2019
|
That's really cool change, thank you very much @cstamas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains some notable internal changes (most importantly related to
HttpChannel.State):
jetty/jetty.project@bde8646#diff-68e74a60841dd5ec1f7edc4bd736ce18
Fix InstrumentedHandler to compile and work with pre-9.4.21 and
post-9.4.21 Jetty instances, but using internal API is not a recipe
for longevity.
Also, created a new InstrumentedHttpChannelListener that in turn
does use public API of Jetty, and should not break with minor
releases.