Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baseApiUrl #847

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Fix baseApiUrl #847

merged 3 commits into from
Nov 3, 2021

Conversation

mtruong-dbx
Copy link
Contributor

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does npm test pass?
  • Does npm run build pass?
  • Does npm run lint pass?

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #847 (8ebec08) into main (86092fb) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
+ Coverage   65.46%   65.55%   +0.08%     
==========================================
  Files           7        7              
  Lines         779      781       +2     
==========================================
+ Hits          510      512       +2     
  Misses        269      269              
Flag Coverage Δ
integration 53.90% <50.00%> (-0.02%) ⬇️
unit 64.14% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils.js 92.00% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86092fb...8ebec08. Read the comment docs.

src/utils.js Outdated Show resolved Hide resolved
@mtruong-dbx mtruong-dbx merged commit 0fd7f5d into main Nov 3, 2021
@mtruong-dbx mtruong-dbx deleted the base-api-url branch November 3, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants