Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bitbucket link handling for branches with slashes #47

Merged
merged 3 commits into from
Dec 19, 2019

Conversation

christianruhstaller
Copy link
Contributor

Bitbucket has a bug where the "source view" link for a branch
which contains a slash results in a 404.

The link to the "branch view" works with names containing
a slash so we do this for branches with slashes in its names.

See https://jira.atlassian.com/browse/BCLOUD-14422 for more information.

Bitbucket has a bug where the "source view" link for a branch
which contains a slash results in a 404.

The link to the "branch view" works with names containing
a slash so we do this for branches with slashes in its names.

See https://jira.atlassian.com/browse/BCLOUD-14422 for more information.
@christianruhstaller
Copy link
Contributor Author

The suggestions are implemented, any more suggestions? Or is the current pull request good to merge?

@bradrydzewski bradrydzewski merged commit 6f3e892 into drone:master Dec 19, 2019
jstrachan pushed a commit to jstrachan/go-scm that referenced this pull request Dec 22, 2020
fix: Add fake implementation for Status operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants