Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non- Cell Ranger SAM tags #48

Merged
merged 2 commits into from
May 15, 2024

Conversation

mschilli87
Copy link
Contributor

@mschilli87 mschilli87 commented Feb 26, 2024

Cell Ranger uses CB SAM tags for the cell barcode and UB SAM tags for the UMI but other scRNA-seq pipelines use different tags (e.g. XC and XM).
This commit introduces the CELL_TAG and UMI_TAG environment variables to override the Cell Ranger style defaults.

Note: For Demuxalot, this requires upstream changes suggested in the following PR: arogozhnikov/demuxalot#26introduced in v.0.4.1. Therefore, it not only does it depend on that one to be merged (which should happen 'soon'), but also on updating the Demuxalot version bundled in the Demuxafy Singularity Image to one including those upstream changes (>= v.0.4.1). Thus, this PR must not be merged before #46 (or, IMHO better: #47) is merged as well.


@drneavin: Merging this and releasing a new version would enable me to use Demuxafy on a lot of data we already have analysed without having to re-analyse them all from scratch with Cell Ranger. I have tested those changes locally using the (reduced) test dataset as well as one of my non- Cell Ranger datasets.

Cell Ranger uses `CB` SAM tags for the cell barcode and `UB` SAM tags
for the UMI but other scRNA-seq pipelines use different tags (*e.g.*
`XC` and `XM`).
This commit introduces the `CELL_TAG` and `UMI_TAG` environment
variables to override the Cell Ranger style defaults.

Note: For Demuxalot, this requires v.0.4.1 or higher.
@mschilli87 mschilli87 marked this pull request as ready for review May 14, 2024 06:31
@mschilli87
Copy link
Contributor Author

mschilli87 commented May 14, 2024

@drneavin: I rebased this on your v3.0.0 branch and resolved all conflicts. Note that this now partially overlaps changes you already did. I can either adjust this PR based on your feedback or you can use it a reference for your own commits.
Let me know how I can best assist you.

@drneavin drneavin merged commit 847608e into drneavin:v3.0.0 May 15, 2024
@mschilli87 mschilli87 deleted the custom_sam_tags branch May 16, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants