Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Lower case enums and better Swift 4 compatibility #134

Merged

Conversation

norio-nomura
Copy link
Contributor

  • Change cases of IndexingError to lowercase
    • Init(instance: AnyObject) is renamed to initialize(instance: AnyObject) since init is recognized as initializer.
  • Change cases of XMLIndexer to lowercase
  • @available of XMLIndexer.Element is guarded by #if !swift(>=3.2) for avoiding SR-4951.
    Current Swift 4 compiler with -swift-version 3 seems Swift 3.2. It may be necessary to change this when Xcode 9 beta starts in the future.

@codecov-io
Copy link

codecov-io commented May 22, 2017

Codecov Report

Merging #134 into version-4.0-changes will decrease coverage by 0.43%.
The diff coverage is 37.71%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           version-4.0-changes    #134      +/-   ##
======================================================
- Coverage                27.63%   27.2%   -0.44%     
======================================================
  Files                       13      13              
  Lines                     1885    1915      +30     
======================================================
  Hits                       521     521              
- Misses                    1364    1394      +30
Impacted Files Coverage Δ
Tests/SWXMLHashTests/XMLParsingTests.swift 0% <0%> (ø) ⬆️
Source/SWXMLHash.swift 76.9% <35.13%> (-5.38%) ⬇️
Source/SWXMLHash+TypeConversion.swift 61.99% <43.58%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac2b70...d956382. Read the comment docs.

@drmohundro drmohundro merged commit ee9a874 into drmohundro:version-4.0-changes May 22, 2017
@norio-nomura norio-nomura deleted the nn-lowercase-enums branch May 23, 2017 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants