-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XMLElement.text
will never be nil.
#132
Comments
As a result the last parts of description implementation of XMLElement is equilvalent of
|
Per issue #132, XMLElement can't be nil because of how the reduce implementation works. Instead, it will be an empty string. I think this makes more sense than allowing for nils anyway. A lot of the suggestions mentioned on issue #84 are related to reducing the number of nil checks as well, so this should help alleviate some of that.
Good catch! It looks like this will result in a breaking change (anyone using the library will have to change from I just pushed version-4.0-changes branch to begin tracking this change. I'd like to get some of the other features from #84 pulled in before I release the next major release. Thanks again for noticing this! |
FYI, this was resolved with |
When implementing #131 , I found that the type of
XMLElement.text
can be changed toString
fromString?
without modify the implementing.That is confirmed by making change like this and it is compiled successfully: ainopara@8e225b7
The text was updated successfully, but these errors were encountered: