-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[drizzle-valibot]: Update for valibot 0.31.0+ #2860
Open
camflan
wants to merge
5
commits into
drizzle-team:main
Choose a base branch
from
camflan:update-drizzle-valibot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camflan
changed the title
Update drizzle-valibot for valibot 0.31.0+
[drizzle-valibot]: Update for valibot 0.31.0+
Aug 27, 2024
Happy to help if there are any questions about Valibot! |
Would love some eyes on this @drizzle-team @dankochetov @AndriiSherman @AlexBlokh |
Is this something we can just use to patch drizzle? :) |
I tried patching but was getting some errors when using forwarding such as... const itemSchema = v.pipe(
v.omit(
v.object({
...createInsertSchema(items, {
groups: v.optional(v.array(group), [])
}).entries,
tags: v.optional(v.array(tagSchema), [])
}),
['createdAt', 'updatedAt']
),
v.forward(
v.partialCheck(
[
['groups']
],
(input) => new Set(input.groups.map((p) => p.label)).size === input.groups.length,
'Group labels must be unique'
)
)
); |
Any progress on this? It's been idle for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up from #2481, brings it up to the latest
main
changes to resolve issues with Valibot 0.31.0+Fixes #2521
Also addresses,
lint
ondrizzle-orm
. This was caused by an invalid comment symbol in the command, used to disable another command. (Was// # lint
instead of# lint
)build
step ontypebox
,valibot
, andzod
validation adapters. Thebuild
commands were using an older version oftsx
specified by local deps, not the version oftsx
which is specified at the top-level package.json