Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[drizzle-orm]: add CASE WHEN expression #2812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[drizzle-orm]: add CASE WHEN expression #2812

wants to merge 1 commit into from

Conversation

louneskmt
Copy link

@louneskmt louneskmt commented Aug 20, 2024 •
edited
Loading

Humble attempt at a typed CASE WHEN expression. Not quite sure I'm using the right Drizzle types everywhere, please let me know.

Usage:

caseWhen(eq(table1.column, 'condition1')).then('bar1')
  .when(eq(table1.column, 'condition2')).then(table2.otherColumn)
  // [ .when( ... ]
  .else(sql<string>`'default'`)
  .end()

Closes #1065.

juliusmarminge
juliusmarminge reviewed Aug 23, 2024
View reviewed changes
drizzle-orm/src/sql/expressions/conditional.ts
};

return {
then: <T extends SQL | SQLWrapper | Column>(value: T) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overloading .then() seems a bit fishy to me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, any other idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: native CASE WHEN support
2 participants
@louneskmt @juliusmarminge