Adds browser-file/field in package.json. #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the functionality of using the browsers implementation of XMLHttpRequest when this module is used in the browser. The browser-field in package.json points to the file which should be used if compiled with a tool that supports this feature. Really convenient if you're building stuff that will run in both server and browser environments.
Open
|
Any reason not to accept this super-useful PR? |
|
+1 |
acinader
pushed a commit
to acinader/node-XMLHttpRequest
that referenced
this pull request
Mar 2, 2016
Tell webpack to mock fs and child_process when packaging for the browser. This will fix driverdan#89 and is lighter-weight than driverdan#66.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the functionality of using the browsers implementation of
XMLHttpRequest when this module is used in the browser. The browser-field in
package.json points to the file which will be used if compiled with a tool
that supports this feature.
Really convenient if you're building stuff that will run in both server and
browser environments.