Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor branching structure for finetuning vs. resuming training #229

Merged
merged 29 commits into from
Sep 24, 2022
Merged

Refactor branching structure for finetuning vs. resuming training #229

merged 29 commits into from
Sep 24, 2022

Commits on Sep 23, 2022

  1. refactor to branch on is_subset and add validation

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    28093a9 View commit details
    Browse the repository at this point in the history

  2. load labels; faster hparams loading; return values

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    88c08df View commit details
    Browse the repository at this point in the history

  3. return model

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    246a340 View commit details
    Browse the repository at this point in the history

  4. put below file validation

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9f46fdc View commit details
    Browse the repository at this point in the history

  5. use pre validator and set predict_all_zamba_species as an optional bool

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9ee904e View commit details
    Browse the repository at this point in the history

  6. rename predict_all_zamba_species to use_default_model_labels

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    568414e View commit details
    Browse the repository at this point in the history

  7. udpate description

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9583088 View commit details
    Browse the repository at this point in the history

  8. set use_default_model_labels to False if not a subset

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    3e1f67a View commit details
    Browse the repository at this point in the history

  9. add table to docs, reorganize and condense slightly

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    8d657be View commit details
    Browse the repository at this point in the history

  10. modify set operaiton

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    23849c4 View commit details
    Browse the repository at this point in the history

  11. make function for getting model hparams

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    93b7627 View commit details
    Browse the repository at this point in the history

  12. look up default model

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    5da1f7c View commit details
    Browse the repository at this point in the history

  13. handle enums

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    0e0c58f View commit details
    Browse the repository at this point in the history

  14. set col order explicitly

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    72df5b2 View commit details
    Browse the repository at this point in the history

  15. we do not need to sort anymore since we set the cols explicitly

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    74d753a View commit details
    Browse the repository at this point in the history

  16. remove unused params; set default labels explciitly to True for one t… 

    …est since the default is now none
    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    b0b2bfe View commit details
    Browse the repository at this point in the history

  17. do not use pre validator; instead set default as none and set to true… 

    … as is relevant; also download checkpoint in config so we do not have to track all the relevant params all the way to instantiate model
    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    0268b15 View commit details
    Browse the repository at this point in the history

  18. further simplify instantiate_model since we download the checkpoint i… 

    …n validation; use helper functions to look up hparams; set defaults to none
    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    eb5f1a9 View commit details
    Browse the repository at this point in the history

  19. get default hparams for a model using the hparams file

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    2b85711 View commit details
    Browse the repository at this point in the history

  20. update test to reflect that use_default_model_labels gets set in config

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    0012cc2 View commit details
    Browse the repository at this point in the history

  21. linting and fix ordering of code for getting species

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    df229f8 View commit details
    Browse the repository at this point in the history

  22. move prediction first and then load labels afterwards

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e0ff293 View commit details
    Browse the repository at this point in the history

  23. add validation test

    @ejm714
    ejm714 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    7333042 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. code review

    @ejm714
    ejm714 committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    e57f00a View commit details
    Browse the repository at this point in the history

  2. remove space

    @ejm714
    ejm714 committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    af46ab4 View commit details
    Browse the repository at this point in the history

  3. revert to is

    @ejm714
    ejm714 committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    1275b7f View commit details
    Browse the repository at this point in the history

  4. use actual models

    @ejm714
    ejm714 committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    239f32a View commit details
    Browse the repository at this point in the history

  5. move comments

    @ejm714
    ejm714 committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    08fc411 View commit details
    Browse the repository at this point in the history

  6. use default model species lookup with model_name

    @ejm714
    ejm714 committed Sep 24, 2022
    Configuration menu
    Copy the full SHA
    7ce62f1 View commit details
    Browse the repository at this point in the history