Exit when there is no valid imagery for any point #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://cyfi-pr-136.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cmcat3mct0pc7385i00g. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 12 12
Lines 860 863 +3
=====================================
+ Hits 645 648 +3
Misses 215 215
|
klwetstone
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
@ejm714 Looks good to me! Just one question making sure our tests will continue to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an edge case where there is no valid imagery for any point (hit this when testing out a single point in a cloudy month). This PR adds code to log the error and the exit.