Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live tests for #484 #505

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Live tests for #484 #505

merged 2 commits into from
Feb 27, 2025

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Feb 25, 2025

  • add timeout support

  • no implicit optional

  • add optional retry

  • black

  • try this

  • type annotations

* add timeout support

* no implicit optional

* add optional retry

* black

* try this

* type annotations

---------

Co-authored-by: Chris Marais <chris.marais@satalia.com>
Copy link
Contributor

github-actions bot commented Feb 25, 2025

@github-actions github-actions bot temporarily deployed to pull request February 25, 2025 19:28 Inactive
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.7%. Comparing base (e2e8035) to head (bf0f092).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cloudpathlib/gs/gsclient.py 90.9% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #505     +/-   ##
========================================
- Coverage    93.8%   93.7%   -0.1%     
========================================
  Files          23      23             
  Lines        1797    1805      +8     
========================================
+ Hits         1686    1692      +6     
- Misses        111     113      +2     
Files with missing lines Coverage Δ
cloudpathlib/gs/gsclient.py 91.2% <90.9%> (-0.3%) ⬇️

... and 2 files with indirect coverage changes

@github-actions github-actions bot temporarily deployed to pull request February 27, 2025 01:04 Inactive
@pjbull pjbull merged commit f98f670 into master Feb 27, 2025
25 checks passed
@pjbull pjbull deleted the 484-live-tests branch February 27, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants