Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes duplicate entries and adds a test #249

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fixes duplicate entries and adds a test #249

merged 2 commits into from
Sep 12, 2024

Conversation

peterfox
Copy link
Collaborator

Changes

  • Fixes the duplicate entries for the LaravelSetProvider
  • Adds a unit test to check if it's providing the sets correctly.

Why

Picked up as a mistake from #248

@peterfox peterfox self-assigned this Sep 12, 2024
@peterfox peterfox mentioned this pull request Sep 12, 2024
Merged
@TomasVotruba
Copy link
Collaborator

LGTM 👍

@GeniJaho GeniJaho merged commit 321a7f8 into main Sep 12, 2024
5 checks passed
@GeniJaho GeniJaho deleted the fix/laravel-set-provider branch September 12, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeniJaho GeniJaho Awaiting requested review from GeniJaho

Assignees

@peterfox peterfox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterfox @TomasVotruba @GeniJaho