Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Rector 1.2.5 and fix compatible of isObjectType() usage to use ClassLike instead of ClassMethod #247

Conversation

samsonasik
Copy link
Collaborator

@samsonasik
Copy link
Collaborator Author

Fixed 🎉 /cc @nick-smit @u01jmg3

@samsonasik samsonasik changed the title Bump to Rector 1.2.5 and fix compatible of isObjectType() usage use use ClassLike instead of ClassMethod Bump to Rector 1.2.5 and fix compatible of isObjectType() usage to use ClassLike instead of ClassMethod Sep 9, 2024
@samsonasik
Copy link
Collaborator Author

@peterfox Ready to merge 👍

@peterfox peterfox merged commit 3ec89de into driftingly:main Sep 9, 2024
5 checks passed
@samsonasik samsonasik deleted the bump-rector-125-and-fix-compatible-isobject-type-code branch September 9, 2024 12:33
@samsonasik
Copy link
Collaborator Author

@peterfox it is better to create immediate patch release imo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddArgumentDefaultValueRector seems to be crashing since rector version 1.2.5
2 participants