Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant default arguments in Laravel 9 Set #221

Merged

Conversation

GeniJaho
Copy link
Collaborator

@GeniJaho GeniJaho commented Jun 2, 2024

Fixes #220.

This PR also handles similar cases in the Laravel 9 set, where we add redundant default variables, and covers with tests all the changes of the set.

Copy link
Collaborator

@peterfox peterfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me @GeniJaho 🎉

@driftingly driftingly merged commit ae7794f into driftingly:main Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

laravel90 set unnecessarily adding null argument to Model::touch()
3 participants