Remove redundant ArgumentAdderRector for nullable arguments #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
The 3 rules can be safely removed, as the methods previously did not expect a second parameter (framework change link).
The only class where the
as
parameter was put in the middle of two other parameters wasIlluminate/Database/Capsule/Manager::table()
, so I left that in the Laravel 6 set. The chances of extending it are small and, in that case, this rule would probably help.Ideally, we'd also modify the original
ArgumentAdderRector
class to not add these default parameters in MethodCalls or StaticCalls, but that's another more complex problem.