Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ArgumentAdderRector for nullable arguments #203

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

GeniJaho
Copy link
Collaborator

Fixes #110

The 3 rules can be safely removed, as the methods previously did not expect a second parameter (framework change link).

The only class where the as parameter was put in the middle of two other parameters was Illuminate/Database/Capsule/Manager::table(), so I left that in the Laravel 6 set. The chances of extending it are small and, in that case, this rule would probably help.

Ideally, we'd also modify the original ArgumentAdderRector class to not add these default parameters in MethodCalls or StaticCalls, but that's another more complex problem.

@driftingly driftingly merged commit d0c1864 into driftingly:main Apr 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgumentAdderRector for nullable arguments should not be added
2 participants