[Laravel100] Adds ReplaceExpectsMethodsInTests rule #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
expectsJobs
andexpectsEvents
.Why
It's mentioned in the Laravel Upgrade guides and this rule is quite useful in that it will insert the assertions at the end of the tests' method statements as the best way of handling this change via Rector.
Notes
I can't make this work for
expectsNotifications
as notification assertions require the notifiable to be checked and as there is no way to know the context of that from a test, only the jobs and events can be handled properly via Rector. The closest guess would be to useassertSentTimes
and put 1 as a default which if that's the case it would be best done with an additional rule.