Allow configuring EloquentOrderByToLatestOrOldestRector

[johnbacon]

Resolves #147.

• Allows an ALLOWED_PATTERNS array of strings to apply this rule to
• Adds additional test items for variable handling

Notes

• The way this is implemented, it will always change created_at columns (as it did before)
• Because static analysis cannot get the value of a variable, we instead allow for specifying variable names

Tested

• Current test scenario
• Scenario where no rule configuration is present

[driftingly]

We use composer docs to update the docs using symplify/rule-doc-generator.
Can you ensure your changes are compatible?

[johnbacon]

@driftingly That should be done now! Thanks for the heads up, it wasn't compatible without changes.

[peterfox]

a couple things I'd consider changing

[peterfox]

Would probably be better to exist in their own file like skip_if_not_eloquent_builder.php.inc

// skip_if_column_not_allowed.php.inc
<?php

namespace RectorLaravel\Tests\Rector\Cast\DatabaseExpressionCastsToMethodCall\Fixture;

$query->orderBy($unallowed_variable_name);
$query->orderBy('unallowed_column_name');

?>

[johnbacon]

I can do this, but I thought these would be unallowed not because they weren't an instance of Builder but because they weren't desired to be automatically refactored. Does it still make sense to move to a different file? I'm not familiar with best practices in this regard.

[driftingly]

I think @peterfox is saying to create a file called skip_if_column_not_allowed.php.inc or skip_if_column_not_configured.php.inc similar to how he did with with the EloquentOrderByToLatestOrOldestRector fixtures.

[johnbacon]

Got it! At least... I think I got it. I don't have any experience with this at this point, besides following orders. Please let me know if I need to do something else!