Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reverted Laravel 10 rule (getBaseQuery -> toBase) #130

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented Aug 22, 2023

The deprecated getBaseQuery was initially removed, but then it was added back because it caused a regression.

Closes #129

@joelvh
Copy link
Contributor Author

joelvh commented Aug 30, 2023

FYI the Laravel upgrade docs have been updated to remove this change from the list

@driftingly driftingly merged commit 1e576f3 into driftingly:main Sep 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getBaseQuery -> toBase was reverted in Laravel 10
2 participants