release PHP 7.2 downgraded 0.30.0

driftingly · Jan 11, 2024 · 871a592 · 871a592
1 parent 4838557
commit 871a592
Show file tree

Hide file tree

Showing 373 changed files with 865 additions and 8,437 deletions.
diff --git a/.github/workflows/code_analysis.yaml b/.github/workflows/code_analysis.yaml
diff --git a/.github/workflows/downgraded_release.yaml b/.github/workflows/downgraded_release.yaml
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
diff --git a/build/composer-php-72.json b/build/composer-php-72.json
diff --git a/build/rector-downgrade-php-72.php b/build/rector-downgrade-php-72.php
diff --git a/composer.json b/composer.json
@@ -4,50 +4,17 @@
     "license": "MIT",
     "description": "Rector upgrades rules for Laravel Framework",
     "require": {
-        "php": ">=8.2",
+        "php": "^7.2 || ^8.0",
         "rector/rector": "^0.19.0"
     },
-    "require-dev": {
-        "phpunit/phpunit": "^10.0",
-        "phpstan/phpstan": "^1.8.2",
-        "symplify/phpstan-rules": "^12.4",
-        "symplify/phpstan-extensions": "^11.0",
-        "symplify/rule-doc-generator": "^11.0",
-        "phpstan/extension-installer": "^1.1",
-        "phpstan/phpstan-webmozart-assert": "^1.1",
-        "phpstan/phpstan-strict-rules": "^1.2",
-        "tightenco/duster": "^2.7"
-    },
     "autoload": {
         "psr-4": {
             "RectorLaravel\\": "src"
         }
     },
     "autoload-dev": {
-        "psr-4": {
-            "RectorLaravel\\Tests\\": "tests"
-        },
         "classmap": ["stubs"]
     },
-    "scripts": {
-        "phpstan": "vendor/bin/phpstan analyse --ansi --error-format symplify",
-        "check-cs": "vendor/bin/duster lint",
-        "fix-cs": "vendor/bin/duster fix",
-        "lint": "vendor/bin/duster lint",
-        "fix": "vendor/bin/duster fix",
-        "rector-dry-run": "vendor/bin/rector process --dry-run --ansi",
-        "rector": "vendor/bin/rector process --ansi",
-        "docs": [
-            "vendor/bin/rule-doc-generator generate src --output-file docs/rector_rules_overview.md --ansi"
-        ]
-    },
     "minimum-stability": "dev",
-    "prefer-stable": true,
-    "config": {
-        "allow-plugins": {
-            "rector/extension-installer": true,
-            "phpstan/extension-installer": true,
-            "cweagans/composer-patches": false
-        }
-    }
+    "prefer-stable": true
 }
diff --git a/config/sets/laravel-array-str-functions-to-static-call.php b/config/sets/laravel-array-str-functions-to-static-call.php
@@ -62,7 +62,9 @@
                     new FuncCallToStaticCall('studly_case', 'Illuminate\Support\Str', 'studly'),
                     new FuncCallToStaticCall('title_case', 'Illuminate\Support\Str', 'title'),
                 ],
-                fn ($function) => ! in_array($function->getOldFuncName(), $internalFunctions, true)
+                function ($function) use ($internalFunctions) {
+                    return ! in_array($function->getOldFuncName(), $internalFunctions, true);
+                }
             )
         );
 };
diff --git a/config/sets/laravel90.php b/config/sets/laravel90.php
@@ -41,22 +41,12 @@
 
     // https://github.com/laravel/framework/commit/e095ac0e928b5620f33c9b60816fde5ece867d32
     $rectorConfig
-        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder(
-            'Illuminate\Database\Eloquent\Model',
-            'touch',
-            0,
-            'attribute',
-        ),
+        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder('Illuminate\Database\Eloquent\Model', 'touch', 0, 'attribute'),
         ]);
 
     // https://github.com/laravel/framework/commit/6daecf43dd931dc503e410645ff4a7d611e3371f
     $rectorConfig
-        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder(
-            'Illuminate\Queue\Failed\FailedJobProviderInterface',
-            'flush',
-            0,
-            'hours',
-        ),
+        ->ruleWithConfiguration(ArgumentAdderRector::class, [new ArgumentAdder('Illuminate\Queue\Failed\FailedJobProviderInterface', 'flush', 0, 'hours'),
         ]);
 
     // https://github.com/laravel/framework/commit/84c78b9f5f3dad58f92161069e6482f7267ffdb6

diff --git a/phpstan.neon b/phpstan.neon
diff --git a/phpunit.xml b/phpunit.xml
diff --git a/src/NodeAnalyzer/LumenRouteRegisteringMethodAnalyzer.php b/src/NodeAnalyzer/LumenRouteRegisteringMethodAnalyzer.php
@@ -11,25 +11,41 @@
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 
-final readonly class LumenRouteRegisteringMethodAnalyzer
+final class LumenRouteRegisteringMethodAnalyzer
 {
-    public function __construct(
-        private NodeTypeResolver $nodeTypeResolver,
-        private NodeNameResolver $nodeNameResolver
-    ) {
+    /**
+     * @readonly
+     * @var \Rector\NodeTypeResolver\NodeTypeResolver
+     */
+    private $nodeTypeResolver;
+    /**
+     * @readonly
+     * @var \Rector\NodeNameResolver\NodeNameResolver
+     */
+    private $nodeNameResolver;
+    public function __construct(NodeTypeResolver $nodeTypeResolver, NodeNameResolver $nodeNameResolver)
+    {
+        $this->nodeTypeResolver = $nodeTypeResolver;
+        $this->nodeNameResolver = $nodeNameResolver;
     }
 
     public function isLumenRoutingClass(MethodCall $methodCall): bool
     {
         return $this->nodeTypeResolver->isObjectType($methodCall->var, new ObjectType('Laravel\Lumen\Routing\Router'));
     }
 
-    public function isRoutesRegisterGroup(Identifier|Expr $name): bool
+    /**
+     * @param \PhpParser\Node\Identifier|\PhpParser\Node\Expr $name
+     */
+    public function isRoutesRegisterGroup($name): bool
     {
         return $this->nodeNameResolver->isName($name, 'group');
     }
 
-    public function isRoutesRegisterRoute(Identifier|Expr $name): bool
+    /**
+     * @param \PhpParser\Node\Identifier|\PhpParser\Node\Expr $name
+     */
+    public function isRoutesRegisterRoute($name): bool
     {
         return $this->nodeNameResolver->isNames($name, ['delete', 'get', 'options', 'patch', 'post', 'put']);
     }

diff --git a/src/NodeAnalyzer/StaticCallAnalyzer.php b/src/NodeAnalyzer/StaticCallAnalyzer.php
@@ -9,11 +9,16 @@
 use PhpParser\Node\Expr\StaticCall;
 use Rector\NodeNameResolver\NodeNameResolver;
 
-final readonly class StaticCallAnalyzer
+final class StaticCallAnalyzer
 {
-    public function __construct(
-        private NodeNameResolver $nodeNameResolver
-    ) {
+    /**
+     * @readonly
+     * @var \Rector\NodeNameResolver\NodeNameResolver
+     */
+    private $nodeNameResolver;
+    public function __construct(NodeNameResolver $nodeNameResolver)
+    {
+        $this->nodeNameResolver = $nodeNameResolver;
     }
 
     public function isParentCallNamed(Node $node, string $desiredMethodName): bool

diff --git a/src/NodeFactory/AppAssignFactory.php b/src/NodeFactory/AppAssignFactory.php
@@ -13,11 +13,16 @@
 use Rector\BetterPhpDocParser\ValueObject\Type\FullyQualifiedIdentifierTypeNode;
 use RectorLaravel\ValueObject\ServiceNameTypeAndVariableName;
 
-final readonly class AppAssignFactory
+final class AppAssignFactory
 {
-    public function __construct(
-        private PhpDocInfoFactory $phpDocInfoFactory
-    ) {
+    /**
+     * @readonly
+     * @var \Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory
+     */
+    private $phpDocInfoFactory;
+    public function __construct(PhpDocInfoFactory $phpDocInfoFactory)
+    {
+        $this->phpDocInfoFactory = $phpDocInfoFactory;
     }
 
     public function createAssignExpression(