program: handle underflow in calculate_liability_transfer_to_cover_ma… #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbigz
reviewed
Dec 18, 2023
| @@ -68,7 +68,7 @@ pub fn calculate_liability_transfer_to_cover_margin_shortage( | |||
| if_liquidation_fee: u32, | |||
| ) -> DriftResult<u128> { | |||
| // If unsettled pnl asset weight is 1 and quote asset is 1, this calculation breaks | |||
| if asset_weight == liability_weight && asset_weight >= liability_weight { | |||
| if asset_weight >= liability_weight { | |||
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #774 +/- ##
==========================================
+ Coverage 74.55% 74.57% +0.01%
==========================================
Files 126 126
Lines 29469 29477 +8
==========================================
+ Hits 21972 21983 +11
+ Misses 7497 7494 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rgin_shortage