program: fill_perp checks maintenance margin req if position is reduced #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
==========================================
+ Coverage 74.40% 74.49% +0.09%
==========================================
Files 125 125
Lines 28940 29054 +114
==========================================
+ Hits 21533 21645 +112
- Misses 7407 7409 +2
|
0xbigz
reviewed
Nov 24, 2023
programs/drift/src/math/orders.rs
Outdated
| based_asset_amount_filled: i64, | ||
| market_index: u16, | ||
| ) -> DriftResult<MarginRequirementType> { | ||
| let current_position = maker |
There was a problem hiding this comment.
this is position after fill? maybe good to specify somewhere
0xbigz
reviewed
Nov 24, 2023
programs/drift/src/math/orders.rs
Outdated
| let position_before = current_position.safe_sub(based_asset_amount_filled)?; | ||
|
|
||
| if current_position.signum() == position_before.signum() | ||
| && current_position.abs() < position_before.abs() |
There was a problem hiding this comment.
good candidate for helper function
position_after.was_reduced(position_before)
crispheaney
force-pushed
the
crispheaney/position-reducing-maker-maint-check
branch
from
e9acb73 to
229ad5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.