openbook v2 #1112
Merged
openbook v2 #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
reviewed
Jun 30, 2024
|
wasnt able to get the tests to run using rust 1.70 |
soundsonacid
reviewed
Jul 1, 2024
fill long fill short - ok
remove serum calculation where was assumed fee 0.04 %
remove fee - placetakeorder is without fee, market maker can have rebates - acrued fee can be misleading ...
discriminator for open orders account
ability to add - open orders accounts to fulfillment via openbook v2 - the fill will not create need to crank if open orders accounts are correct.
correction
open orders account passing - working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openbook V2 integration with integration test in rust ...