program: enforce min order size when trading against amm (#334)

* program: enforce min order size when trading against amm * CHANGELOG
drift-labs · Jan 24, 2023 · 3cdd67c · 3cdd67c
1 parent 6d87997
commit 3cdd67c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Features
 
+- program: enforce min order size when trading against amm ([#334](https://github.com/drift-labs/protocol-v2/pull/334))
+
 ### Fixes
 
 ### Breaking

diff --git a/programs/drift/src/controller/orders.rs b/programs/drift/src/controller/orders.rs
@@ -1513,10 +1513,14 @@ pub fn fulfill_perp_order_with_amm(
         }
     };
 
-    if base_asset_amount == 0 {
+    if base_asset_amount < market.amm.min_order_size {
         // if is an actual swap (and not amm jit order) then msg!
         if override_base_asset_amount.is_none() {
-            msg!("Amm cant fulfill order");
+            msg!(
+                "Amm cant fulfill order. base asset amount {} market.amm.min_order_size {}",
+                base_asset_amount,
+                market.amm.min_order_size
+            );
         }
         return Ok((0, 0));
     }

diff --git a/programs/drift/src/state/perp_market.rs b/programs/drift/src/state/perp_market.rs
@@ -477,7 +477,7 @@ impl Default for AMM {
             funding_period: 0,
             order_step_size: 0,
             order_tick_size: 0,
-            min_order_size: 0,
+            min_order_size: 1,
             max_position_size: 0,
             volume_24h: 0,
             long_intensity_volume: 0,

diff --git a/sdk/src/math/orders.ts b/sdk/src/math/orders.ts
@@ -165,12 +165,12 @@ export function isFillableByVAMM(
 ): boolean {
 	return (
 		(isAuctionComplete(order, slot) &&
-			!calculateBaseAssetAmountForAmmToFulfill(
+			calculateBaseAssetAmountForAmmToFulfill(
 				order,
 				market,
 				oraclePriceData,
 				slot
-			).eq(ZERO)) ||
+			).gte(market.amm.minOrderSize)) ||
 		isOrderExpired(order, ts)
 	);
 }