Add user details #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,7 +87,7 @@ public void invokeService(final RenderRequest req, final RenderResponse res) { | |||
| IOUtils.copy(entity.getContent(), res.getPortletOutputStream()); | |||
|
|
|||
| } catch (IOException e) { | |||
| logger.error("Failed to invoke serviceUrl '{}'", serviceUrl); | |||
| logger.error("Failed to invoke serviceUrl '{}' with reason {}", serviceUrl, e.getMessage()); | |||
There was a problem hiding this comment.
Thanks! (I was moving really quickly.)
|
I'm working on ideas for a first draft data model: https://github.com/drewwills/Soffit/wiki/Soffit-Connector-Data-Model |
| @@ -118,6 +118,9 @@ private SoffitRequest buildSoffitRequest(final RenderRequest req, final RenderRe | |||
| // Namespace | |||
| rslt.setNamespace(res.getNamespace()); | |||
|
|
|||
| // User | |||
| rslt.getUserDetails().setUsername(req.getUserPrincipal().getName()); | |||
There was a problem hiding this comment.
Just a heads up -- this whole data model about to be replaced by this: https://github.com/drewwills/Soffit/wiki/Soffit-Connector-Data-Model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add a very basic (for now at least) UserDetails object to the SoffitRequest. The name was chosen to mirror Spring Security's nomenclature, but I'm not stuck to it; feel free to suggest something else.
This also adds the gradle wrapper, which I simply let gradle set up for me (and I believe is typically best practice for gradle projects -- avoids version conflicts).