Skip to content

Commit

Permalink
Disable DTB error info bars for now
Browse files Browse the repository at this point in the history
We see these errors popping up during regular operations such as branch switches. I'd hoped that they would present themselves as cancellations, however we don't see ` BuildCanceledEventArgs` in our logger. These are advertised as real failures. There's nothing the user can do about these, so it's not helpful to tell the user about them.

I hope to revisit this in 17.14 to see if there's still a way to provide helpful warnings when actionable errors occur, without any noise from internal and unactionable errors.
  • Loading branch information
drewnoakes committed Jan 22, 2025
1 parent d1d243a commit b42d0d4
Showing 1 changed file with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using Microsoft.Build.Framework;
using Microsoft.VisualStudio.Imaging;
using Microsoft.VisualStudio.ProjectSystem.Build;
using Microsoft.VisualStudio.ProjectSystem.Properties;
using Microsoft.VisualStudio.ProjectSystem.VS.UI.InfoBars;
Expand Down Expand Up @@ -183,6 +182,14 @@ void SendTelemetry()

void ReportBuildErrors()
{
// Disabled for now, as we have too many false positives. Will revisit.

// (These lines prevent compile warnings.)
_ = projectFaultHandlerService;
_ = infoBarService;
_ = project;

/*
if (_succeeded is not false)
{
// Only report a failure if the build failed. Specific targets can have
Expand All @@ -197,6 +204,7 @@ void ReportBuildErrors()
KnownMonikers.StatusError,
CancellationToken.None),
project.UnconfiguredProject);
*/
}
}

Expand Down

0 comments on commit b42d0d4

Please sign in to comment.