Testing dojo solutions #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewmoore
approved these changes
Jul 10, 2020
| @@ -22,8 +22,9 @@ const localisePrice = (price, locale) => { | |||
| * Implement me! | |||
| * Hint: .toFixed() might help... | |||
| */ | |||
| price = price.toFixed(2).toString(); | |||
There was a problem hiding this comment.
This works, but I would generally advise assigning this to a new variable. Reassigning function arguments can be problematic. It changes a function's arguments property. Here's an article that explains this concept: https://spin.atomicobject.com/2011/04/10/javascript-don-t-reassign-your-function-arguments/.
There was a problem hiding this comment.
Got it! Will never do it again😄 Thanks!
| return allNames; | ||
| const namesLimited = allNames.slice(0,limit); | ||
|
|
||
| return limit ? namesLimited : allNames; |
There was a problem hiding this comment.
Here, I would advise only performing the .slice() operation if there is a limit. If there is not a need for it, then it is more optimal to return allNames. For example, you could do:
return !limit ? allNames : allNames.slice(0,limit);
There was a problem hiding this comment.
Oh yes, you are totally right! 🙏 Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Andrew!
Thanks for the great hands-on session, I really loved it! 🙂
I created this pull request so if you have some time to check it out maybe and give some suggestions how to improve my code that would super cool and more than welcome!
Have a nice day!
Arpi