Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#43] Update repo structure to https://github.com/AlexSkrypnyk/scaffold #44

Merged
merged 16 commits into from
Dec 25, 2023
Merged

[#43] Update repo structure to https://github.com/AlexSkrypnyk/scaffold #44

merged 16 commits into from
Dec 25, 2023

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Dec 22, 2023

#43

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

*/
abstract class AbstractIntegrationTest extends AbstractTest
abstract class AbstractIntegrationTestCase extends AbstractTestCase
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I update phpunit to 10, we need to create abstract class without suffix Test.

/**
* A new ErrorException class.
*/
class ErrorException extends Exception
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPunit 10 does not have PHPUnit\Framework\Error\Error.
I created this class to solve the missing class issue.

@tannguyen04 tannguyen04 marked this pull request as ready for review December 25, 2023 04:08
@AlexSkrypnyk AlexSkrypnyk merged commit b5c0549 into drevops:master Dec 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants