Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of config/temperature for various Xiaomi devices #7827

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mattreim
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jun 29, 2024

Hey @mattreim, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDB changes

Modified

  • xiaomi/xiaomi_wxkg11lm_mini_switch.json : Wireless mini switch (WXKG11LM) ✔️

  • xiaomi/lumi_sensor_wleak_aq1.json : Water leak sensor (SJCGQ11LM) ✔️

  • xiaomi/xiaomi_mccgq11lm_openclose_sensor.json : Open/close sensor (MCCGQ11LM) ✔️

  • xiaomi/lumi_motion_ac01.json : FP1 human presence sensor (RTCZCGQ11LM) ✔️

  • xiaomi/lumi_vibration_aq1.json : Vibration sensor (DJT11LM) ✔️

  • xiaomi/xiaomi_rtcgqq11lm_presence_sensor.json : Motion sensor (RTCGQ11LM) ✔️

Validation

Tip

Everything is fine !

🕟 Updated for commit 19eb20f

@mattreim mattreim changed the title Removal of config/temperature for various Xiaomi devices Removal of config/temperature for various Xiaomi devices Jun 29, 2024
@ebaauw ebaauw self-requested a review June 29, 2024 18:59
Copy link
Collaborator

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this; config/temperature has been nothing but confusion. I think we should remove it from all Xiaomi devices and deprecate the resource item (I don't think it's used by other devices).

@@ -46,6 +46,19 @@
},
{
"name": "attr/swversion",
"parse": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already reported through the Xiaomi special attribute?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip, I'll try it again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work.

@@ -138,6 +140,19 @@
},
{
"name": "attr/swversion",
"parse": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already reported through the Xiaomi special attribute?

@SwoopX
Copy link
Collaborator

SwoopX commented Jun 30, 2024

I definitively support this one as well. However, there's probably more devices out there where this should be done and then the universe will start yelling at us that we must bring this back. As I recall, none of the DDFs initially had that temperature crazyness included at the very beginning and not even Xiaomi is neither offering nor making any use of that value.

@mattreim
Copy link
Contributor Author

mattreim commented Oct 7, 2024

Over time it turned out that the sensor didn't recognize the version after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants