-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Dots in the schema name do not parse correctly #203
Labels
bug
Something isn't working
Comments
To fix this issue: Add to line 22 Replace Line 50 with:
Create your schema using double quotes when specifying a single space/folder and single quotes around the entire schema like the following:
|
could you open a PR for the fix you suggested please |
brock-acryl
added a commit
to brock-acryl/dbt-dremio
that referenced
this issue
Sep 6, 2023
fix for dremio#203
Merged
1 task
ravjotbrar
added a commit
that referenced
this issue
Nov 14, 2023
### Summary Prior to this change, users would not be able to specify a schema with a dot in it. For instance, schema.parse would get quoted as "schema"."parse", even though the user intended to quote the entire identifier. Now users can choose to wrap the schema in single quotes and add double quotes around the parts they want. ### Description Add regex to match a pattern containing quotes. Solution provided by @dremio-brock. ### Test Results All tests pass. ### Changelog - [x] Added a summary of what this PR accomplishes to CHANGELOG.md ### Related Issue #203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current Behavior
When using a dot (.) in a schema name, dbt will parse this and split out the schema to read:
"samples"."dremio"."com"
instead of
"samples.dremio.com"
Expected Behavior
dbt should parse schema as: "samples.dremio.com"
Steps To Reproduce
Create a schema.yaml file containing the following
Environment
Relevant log output
No response
The text was updated successfully, but these errors were encountered: