Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insecure Request Warning #142

Closed
ravjotbrar opened this issue Feb 28, 2023 · 0 comments · Fixed by #146
Closed

Insecure Request Warning #142

ravjotbrar opened this issue Feb 28, 2023 · 0 comments · Fixed by #146
Assignees
@ravjotbrar
Labels
ci/cd code hygiene

Comments

@ravjotbrar
Copy link
Contributor

When running the functional tests, we get the following warning:

InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.dremio.cloud'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings

Solution may be using PoolManager with our requests.
@ravjotbrar ravjotbrar mentioned this issue Mar 3, 2023
Merged
1 task
@ravjotbrar ravjotbrar linked a pull request Mar 3, 2023 that will close this issue
Fix insecure request warning #146
Merged
1 task
@ravjotbrar ravjotbrar self-assigned this Mar 3, 2023
ravjotbrar added a commit that referenced this issue Mar 14, 2023
@ravjotbrar
Fix insecure request warning (#146)
bd6ded4 
### Summary

Fixed the insecure request warning by ensuring ssl verification is
enabled in all of our api calls. In addition, I've added a new config
option called verify_ssl so that this behaviour is configurable by the
user.

### Description

The new config option is set to true by default. I've added this option
to the Parameters class, which we already pass to each api call, instead
of passing ssl_verify as a separate option.

### Test Results

Ran all functional tests against Dremio Cloud:

- Basic tests were flaky at first with one random test failing each
time. But eventually all tests passed. The flaky tests may be related to
#91
- All other func tests passed without an issue

### Changelog

-   [x] Added a summary of what this PR accomplishes to CHANGELOG.md

### Related Issue

#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravjotbrar ravjotbrar

Labels
ci/cd code hygiene
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix insecure request warning dremio/dbt-dremio
1 participant
@ravjotbrar