Can use WatchService API instead of monitor from commons-io #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lterationListenerAdaptor
…ice from Java 7 the monitor from commons-io cause a high CPU usage (com.docker.hyperkit and com.docker.osxfs use 400% on a MacBook Pro) on Docker for Mac see docker/for-mac#82 (comment) using Watch Service can reduce the high CPU usage (from 400% to 2%) known issues - Watch Service will work on pure macOS by polling (just as commons-io): http://stackoverflow.com/questions/9588737/is-java-7-watchservice-slow-for-anyone-else - Watch Service won't work on Docker Toolbox above Win 7: https://www.virtualbox.org/ticket/10660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the monitor from commons-io cause a high CPU usage (com.docker.hyperkit and com.docker.osxfs use 400% on a MacBook Pro) on Docker for Mac when there's 1000+ JSON files.
see docker/for-mac#82 (comment)
using Watch Service can reduce the high CPU usage (from 400% to 2%)
known issues