Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): before edit event can't cancel by formula-bar #4569

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 25, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 25, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 9 seconds
commit  883bd3f
info  For more information, see full report

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 32.63%. Comparing base (bac2965) to head (883bd3f).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 17 Missing ⚠️
...s-ui/src/services/editor/editor-manager.service.ts 0.00% 6 Missing ⚠️
...mula-ui/src/views/range-selector/hooks/useFocus.ts 0.00% 2 Missing ⚠️
...rc/controllers/editor/formula-editor.controller.ts 0.00% 2 Missing ⚠️
packages/core/src/facade/f-univer.ts 0.00% 1 Missing ⚠️
...der-controllers/editor-bridge.render-controller.ts 0.00% 1 Missing ⚠️
packages/sheets-ui/src/facade/f-univer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4569      +/-   ##
==========================================
- Coverage   32.65%   32.63%   -0.02%     
==========================================
  Files        2598     2599       +1     
  Lines      134936   135059     +123     
  Branches    30033    30059      +26     
==========================================
+ Hits        44057    44080      +23     
- Misses      90879    90979     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 9fe3d2a into dev Jan 25, 2025
12 checks passed
@weird94 weird94 deleted the fix/facade-before-edit branch January 25, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants