Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): fix event API export #4422

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix(filter): fix event API export #4422

merged 3 commits into from
Jan 3, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 3, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 3, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 3, 2025

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  a8443f1
info  For more information, see full report

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.13%. Comparing base (9ad9d48) to head (a8443f1).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/facade/f-enum.ts 0.00% 5 Missing ⚠️
packages/sheets-filter/src/facade/f-event.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4422      +/-   ##
==========================================
- Coverage   33.14%   33.13%   -0.02%     
==========================================
  Files        2548     2549       +1     
  Lines      131410   131451      +41     
  Branches    29285    29289       +4     
==========================================
  Hits        43562    43562              
- Misses      87848    87889      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 5738128 into dev Jan 3, 2025
9 checks passed
@wzhudev wzhudev deleted the fix/filter-api branch January 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants