fix: cursor blink lags when pointer down at text range #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test results
Details
|
|
It's wried that scene.addObject won't call markDirty of layer. now transformByState dirty layer. 
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4180 +/- ##
=======================================
Coverage 33.77% 33.78%
=======================================
Files 2456 2487 +31
Lines 127710 127652 -58
Branches 28603 28599 -4
=======================================
- Hits 43129 43121 -8
+ Misses 84581 84531 -50 ☔ View full report in Codecov by Sentry. |
Jocs
reviewed
Nov 29, 2024
|
Jocs
reviewed
Nov 29, 2024
| }; | ||
|
|
||
| // wait for anchorShape created. | ||
| setTimeout(() => { |
There was a problem hiding this comment.
有了下面 make dirty 是不是不用setTimeout 呢
Jocs
reviewed
Nov 29, 2024
| @@ -121,25 +121,23 @@ export class TextRange implements IDocRange { | |||
| } | |||
|
|
|||
| private _anchorBlink() { | |||
| setTimeout(() => { | |||
Jocs
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
Pull Request Checklist