Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): sheet name normalize string #4172

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 28, 2024

close #4076
close #4002
close #3902 (Not reproduced, just test it)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Dushusir Dushusir requested review from wpxp123456 and removed request for Jocs, wzhudev and jikkai November 28, 2024 09:32
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 28, 2024
@Dushusir Dushusir requested a review from wzhudev November 28, 2024 09:32
Copy link

github-actions bot commented Nov 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 28, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  080a270
info  For more information, see full report

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.79%. Comparing base (59b95fa) to head (080a270).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...src/controllers/formula-alert-render.controller.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4172   +/-   ##
=======================================
  Coverage   33.78%   33.79%           
=======================================
  Files        2485     2485           
  Lines      127547   127561   +14     
  Branches    28594    28594           
=======================================
+ Hits        43093    43104   +11     
- Misses      84454    84457    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/formula-bugs1127 branch from 028e3b3 to ca20b4a Compare November 29, 2024 02:36
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 29, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 29, 2024
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1127 branch 2 times, most recently from 913c5f9 to 8a83562 Compare November 30, 2024 02:53
@Dushusir Dushusir requested a review from weird94 November 30, 2024 02:58
@Dushusir Dushusir force-pushed the dushusir/formula-bugs1127 branch from 8a83562 to 080a270 Compare November 30, 2024 03:16
@Dushusir Dushusir merged commit d9b1149 into dev Nov 30, 2024
9 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bugs1127 branch November 30, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants