-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheet): sheet name normalize string #4172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dushusir
requested review from
wpxp123456
and removed request for
Jocs,
wzhudev and
jikkai
November 28, 2024 09:32
View Deployment
|
Playwright test resultsDetails 20 tests across 9 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4172 +/- ##
=======================================
Coverage 33.78% 33.79%
=======================================
Files 2485 2485
Lines 127547 127561 +14
Branches 28594 28594
=======================================
+ Hits 43093 43104 +11
- Misses 84454 84457 +3 ☔ View full report in Codecov by Sentry. |
Dushusir
force-pushed
the
dushusir/formula-bugs1127
branch
from
November 29, 2024 02:36
028e3b3
to
ca20b4a
Compare
oumomomo
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Nov 29, 2024
Dushusir
force-pushed
the
dushusir/formula-bugs1127
branch
2 times, most recently
from
November 30, 2024 02:53
913c5f9
to
8a83562
Compare
wzhudev
approved these changes
Nov 30, 2024
Dushusir
force-pushed
the
dushusir/formula-bugs1127
branch
from
November 30, 2024 03:16
8a83562
to
080a270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4076
close #4002
close #3902 (Not reproduced, just test it)
Pull Request Checklist