Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto fill should delete dv rules #4075

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: auto fill should delete dv rules #4075

merged 3 commits into from
Nov 25, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 15, 2024

close https://github.com/dream-num/univer-pro/issues/2432

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku requested a review from yuhongz as a code owner November 15, 2024 08:17
Copy link

github-actions bot commented Nov 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 15, 2024
@lumixraku lumixraku requested a review from weird94 November 15, 2024 08:21
Copy link

github-actions bot commented Nov 15, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  ad68337
info  For more information, see full report

@lumixraku lumixraku force-pushed the fix/auto-fill-dv-rules branch 2 times, most recently from 581f10c to 9ff5fdd Compare November 15, 2024 08:25
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 33.73%. Comparing base (bf8329f) to head (ad68337).
Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
...ets/src/commands/commands/utils/selection-utils.ts 0.00% 20 Missing ⚠️
...tion-ui/src/controllers/dv-auto-fill.controller.ts 0.00% 9 Missing ⚠️
packages/core/src/sheets/worksheet.ts 0.00% 5 Missing ⚠️
...n/src/commands/commands/data-validation.command.ts 0.00% 3 Missing ⚠️
...ckages/sheets-data-validation/src/utils/formula.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4075      +/-   ##
==========================================
- Coverage   33.76%   33.73%   -0.04%     
==========================================
  Files        2457     2457              
  Lines      127762   127889     +127     
  Branches    28608    28637      +29     
==========================================
  Hits        43141    43141              
- Misses      84621    84748     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lumixraku lumixraku force-pushed the fix/auto-fill-dv-rules branch 2 times, most recently from d290402 to e20d0e7 Compare November 16, 2024 07:01
@zhaolixin7
Copy link

zhaolixin7 commented Nov 21, 2024

@lumixraku 这个下拉填充未修复,粘贴后数据验证也有问题 https://github.com/dream-num/univer-pro/issues/2432
2024_11_21 11_58_56 video.webm
预期:粘贴和填充后选区被拆分为多个如截图
image

#3016
选中单元格右移、下移后,预期:原单元格不显示边框
表现:原单元格保留了边框
2024_11_21 14_08_42 video.webm

@univer-bot
Copy link

univer-bot bot commented Nov 21, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@lumixraku This drop-down filling has not been fixed, and there is also a problem with data verification after pasting https://github.com/dream-num/univer-pro/issues/2432
2024_11_21 11_58_56 video.webm
Expected: After pasting and filling, the selection is split into multiple pieces as shown in the screenshot
image

#3016
After moving the selected cell to the right or down, expected: the original cell will not display the border.
Performance: The original cell retains its border
2024_11_21 14_08_42 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 21, 2024
@lumixraku
Copy link
Contributor Author

Google sheet 自动填充可以复制现有的数据验证配置

@univer-bot
Copy link

univer-bot bot commented Nov 21, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Google sheet autofill can copy existing data validation configuration

@lumixraku lumixraku force-pushed the fix/auto-fill-dv-rules branch from 477d7a6 to 2fa3b03 Compare November 21, 2024 11:10
@lumixraku lumixraku force-pushed the fix/auto-fill-dv-rules branch from 2fa3b03 to 54c6aa4 Compare November 23, 2024 11:08
@lumixraku lumixraku force-pushed the fix/auto-fill-dv-rules branch from 54c6aa4 to ad68337 Compare November 23, 2024 11:14
@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Nov 25, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 25, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 25, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 25, 2024
@lumixraku lumixraku merged commit b9439c5 into dev Nov 25, 2024
10 checks passed
@lumixraku lumixraku deleted the fix/auto-fill-dv-rules branch November 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants